Re: [alsa-devel] [PATCH] ASoC: nau8824: new driver

On Thu, Apr 20, 2017 at 05:25:11PM +0800, John Hsu wrote:

This is mostly good so I'll apply it but there's a couple of small issues, please send followup patches to address them:

• SOC_SINGLE_TLV("Speaker Right from DACR Volume",

• NAU8824_REG_CLASSD_GAIN_1, 8, 0x1f, 0, spk_vol_tlv),
  

• SOC_SINGLE_TLV("Speaker Left from DACL Volume",

• NAU8824_REG_CLASSD_GAIN_2, 0, 0x1f, 0, spk_vol_tlv),
  

• SOC_SINGLE_TLV("Speaker Left from DACR Volume",

• NAU8824_REG_CLASSD_GAIN_1, 0, 0x1f, 0, spk_vol_tlv),
  

• SOC_SINGLE_TLV("Speaker Right from DACL Volume",

• NAU8824_REG_CLASSD_GAIN_2, 8, 0x1f, 0, spk_vol_tlv),
  

It would be better to name these controls so that they match up with the names of the matching DAPM controls (so "Speaker Right DACR Volume" and so on it seems) so that userspace can join them up with each other.

• /* Class D gain 9db for 1R and 2L */
• regmap_update_bits(regmap, NAU8824_REG_CLASSD_GAIN_1,

• NAU8824_CLASSD_GAIN_1R_MASK,
  

• (0xa << NAU8824_CLASSD_GAIN_1R_SFT));
  

• regmap_update_bits(regmap, NAU8824_REG_CLASSD_GAIN_2,

• NAU8824_CLASSD_GAIN_2L_MASK, 0xa);
  

Leave these at the chip default, they