Re: [PATCH] ASoC: rt5682s: Separate the regulator consumer controls

25 Mar 2022


      On Fri, Mar 25, 2022 at 03:55:32PM +0800, derek.fang@realtek.com wrote:
...
@@ -3025,8 +3025,17 @@ static struct snd_soc_dai_driver rt5682s_dai[] = {
 static void rt5682s_i2c_disable_regulators(void *data)
 {
   struct rt5682s_priv *rt5682s = data;

int ret;

ret = regulator_disable(rt5682s->supplies[RT5682S_SUPPLY_AVDD].consumer);
if (ret)
pr_err("%s: Failed to disable supply AVDD: %d\n", __func__, ret);



Please use dev_err() for error reporting.  Otherwise this looks fine.

    

Mark Brown