10 Oct
2022
10 Oct
'22
3:20 p.m.
пн, 10 окт. 2022 г. в 14:19, Mark Brown broonie@kernel.org:
As covered in submitting-patches.rst this should really be split up into multiple patches, with one change per patch. This is especially the case here since you have a mix of fixes and new features which should be applied differently.
Got it, will rework.
SOC_DOUBLE_R_TLV("Master Capture Volume",
SOC_DOUBLE_TLV("Master Capture Volume",JZ4725B_CODEC_REG_CGR10,REG_CGR10_GIL_OFFSET,REG_CGR10_GIR_OFFSET,0xf, 0, jz4725b_adc_tlv),SOC_DOUBLE_R_TLV("Mixer Line In Bypass Playback Volume", JZ4725B_CODEC_REG_CGR3,This doesn't appear to correspond to what your patch description said
I forgot to mention that in the description, thanks.
and will presumably cause problems for any existing configurations...
I'm curious why this didn't cause problems earlier, as the wrong control was used for the Master Capture Volume.