1 Jun
2007
1 Jun
'07
3:45 p.m.
Liam Girdwood wrote:
Imho, there is little point in probing or allocating any more resources until we know the I2C codec probe succeeds. We would just have to free any resources allocated up to that point.
True, but if the I2C probe fails, then I would think that the whole system is shot, so this sounds like a very unlikely situation. If you changed the code to clean up after an I2C failure, you could make the whole thing more modular, including eliminating the call to snd_soc_new() in the codec driver.
Since ASoC divides everything into four more-or-less independent drivers, it makes sense that it should be able to handle a situation where one of those drivers just fails to load.