Re: [alsa-devel] [PATCH 21/31] ASoC: dapm: Use WARN_ON() instead of BUG_ON()

On Tue, Nov 05, 2013 at 06:40:08PM +0100, Takashi Iwai wrote:

list_for_each_entry(w, pending, power_list) {

• BUG_ON(reg != w->reg);
  

• if (WARN_ON(reg != w->reg))
  

• 	return;
  

  w->power = w->new_power;

This doesn't seem at all sensible - it's going to suddenly abort the entire sequence run over the error which if we're actually trying to continue is just going to make things worse. I'd expect to at most skip over the entry.