16 Sep
2014
16 Sep
'14
9 p.m.
On Tue, Sep 09, 2014 at 03:11:26PM +0530, Subhransu S. Prusty wrote:
- { SST_GAIN_KCONTROL_INT(SST_CONTROL_NAME(xpname, xmname, xinstance, "rampduration"), \
- { SST_GAIN_KCONTROL_BOOL(SST_CONTROL_NAME(xpname, xmname, xinstance, "mute"), \
- { SST_GAIN_KCONTROL_TLV(SST_CONTROL_NAME(xpname, xmname, xinstance, "volume"), \
The macros in here look like they're all going to generate non-standard control names - volume controls should be " Volume", booleans should be " Switch" and I'd expect ramp delay to be written idiomatically as " Ramp Delay". This will confuse standard userspaces which rely on the control names.
I've got a feeling this may be an issue with the previous patch as well.