Re: [alsa-devel] [PATCH 1/4] ASoC: imx-sgtl5000: Do not enter the error path on success

On Wed, Apr 17, 2013 at 10:38 PM, Shawn Guo shawn.guo@linaro.org wrote:

Well, clk_put() shouldn't be called on success, but of_node_put() should.

Ok, then tomorrow I will send v2 as:

diff --git a/sound/soc/fsl/imx-sgtl5000.c b/sound/soc/fsl/imx-sgtl5000.c index 9584e78..5a6aaa3 100644 --- a/sound/soc/fsl/imx-sgtl5000.c +++ b/sound/soc/fsl/imx-sgtl5000.c @@ -174,6 +174,11 @@ static int imx_sgtl5000_probe(struct platform_device *pdev) }

platform_set_drvdata(pdev, data); + of_node_put(ssi_np); + of_node_put(codec_np); + + return 0; + clk_fail: clk_put(data->codec_clk); fail: