Re: [alsa-devel] [PATCH] ASoC: let snd_soc_update_bits() return an error code

On Mon, Jan 10, 2011 at 1:29 PM, Mark Brown broonie@opensource.wolfsonmicro.com wrote:

On Mon, Jan 10, 2011 at 01:28:33PM -0600, Timur Tabi wrote:

...

• ret = old = snd_soc_read(codec, reg);
• if (ret < 0)
• return ret;

Please don't use multiple assignments in a single statement, it does nothing for legibility.

Bummer. I really like that trick. It's just so much more elegant than:

ret = snd_soc_read(codec, reg); if (ret < 0) return ret;

old = ret;