Re: [PATCH 3/9] ASoC: dt-bindings: meson: convert axg tdm interface to schema

On 02/02/2023 19:36, Jerome Brunet wrote:

Convert the DT binding documentation for the Amlogic tdm interface to schema.

Signed-off-by: Jerome Brunet jbrunet@baylibre.com

+title: Amlogic Audio TDM Interfaces

+maintainers:

• • Jerome Brunet jbrunet@baylibre.com

+allOf:

• • $ref: dai-common.yaml#

+properties:

• $nodename:
• pattern: "^audio-controller-.*"

Such pattern is also not correct (see your patch #2), but so far we do not require node naming from individual schemas, so I propose just to drop it.

• compatible:
• items:

Drop items

•  - const: 'amlogic,axg-tdm-iface'
  

Drop quotes

• "#sound-dai-cells":
• const: 0
• clocks:
• minItems: 2
• items:

•  - description: Bit clock
  

•  - description: Sample clock
  

•  - description: Master clock #optional
  

• clock-names:
• minItems: 2
• items:

•  - const: sclk
  

•  - const: lrclk
  

•  - const: mclk
  

+required:

• • compatible
• • "#sound-dai-cells"
• • clocks
• • clock-names

+unevaluatedProperties: false

+examples:

• • |
• #include <dt-bindings/clock/axg-audio-clkc.h>
• tdmif_a: audio-controller-0 {

audio-controller (and drop the label)

•    compatible = "amlogic,axg-tdm-iface";
  

•    #sound-dai-cells = <0>;
  

•    clocks = <&clkc_audio AUD_CLKID_MST_A_SCLK>,
  

•             <&clkc_audio AUD_CLKID_MST_A_LRCLK>,
  

•             <&clkc_audio AUD_CLKID_MST_A_MCLK>;
  

•    clock-names = "sclk", "lrclk", "mclk";
  

• };

Best regards, Krzysztof