On 03/02/16 00:35, Kenneth Westfield wrote:
On Mon, Feb 01, 2016 at 09:28:28AM -0800, Srinivas Kandagatla wrote:
diff --git a/sound/soc/qcom/lpass-platform.c b/sound/soc/qcom/lpass-platform.c index a6dce1b..bfc9de6 100644 --- a/sound/soc/qcom/lpass-platform.c +++ b/sound/soc/qcom/lpass-platform.c @@ -91,7 +91,7 @@ static int lpass_platform_pcmops_hw_params(struct snd_pcm_substream *substream, unsigned int channels = params_channels(params); unsigned int regval; int bitwidth;
- int ret, rdma_port = pcm_data->i2s_port + v->rdmactl_audif_start;
- int ret, rdma_port = pcm_data->i2s_port + v->dmactl_audif_start;
I was wondering why rdma_port had not been changed as well, until I saw that in a later patch. Would it make sense to combine all changes related to removing read-only indications from identifiers to one patch?
Yep, I will see if I can merge this and also I need to fix the ordering, I got same report from 0day testing too.