Re: [alsa-devel] [PATCH] ASoC: core: Pass kcontrol pointer to bytes tlv callbacks

On Wed, Jun 3, 2015 at 4:59 AM, Mark Brown broonie@kernel.org wrote:

On Tue, Jun 02, 2015 at 03:24:03PM -0700, Ben Zhang wrote:

...

• int (*get)(unsigned int __user *bytes, unsigned int size);
  

• int (*put)(const unsigned int __user *bytes, unsigned int size);
  

• int (*get)(struct snd_kcontrol *kcontrol,
  

•            unsigned int __user *bytes, unsigned int size);
  

• int (*put)(struct snd_kcontrol *kcontrol,
  

•            const unsigned int __user *bytes, unsigned int size);
  

This doesn't update any users and we do have some like the Haswell PCM driver.

Hi Mark,

I couldn't find any existing users of the callbacks. It looks like the modified callbacks are used by SND_SOC_BYTES_TLV only, and there is no reference to SND_SOC_BYTES_TLV in the kernel.

The Haswell PCM driver uses SND_SOC_BYTES_EXT which doesn't use the callbacks in struct soc_bytes_ext. The xhandler_get/put are assigned to snd_kcontrol_new.get/put instead.

Ben