Re: [alsa-devel] [PATCH 01/14] parport: return value of attach and parport_register_driver

8 Apr 2015


      On Wed, Apr 08, 2015 at 02:38:32PM +0300, Dan Carpenter wrote:
...

We can't apply this patch on its own so this way of breaking up the

patches doesn't work.
The right thing is to do add an attach_ret().
static int do_attach(drv)
{
    if (drv->attach_ret)
    	return drv->attach_ret();
    drv->attach();
    return 0;
}
Then we convert one driver to use the new function pointer and see if
it simplifies the code.  If so we can transition the others as well.  If
not then we give up.
regards,
dan carpenter