On 7/20/18 5:27 AM, Puneeth Prabhu wrote:
Topology supports maximum of 32 configs for a path whereas kernel can support only 16 configs of a path. So, increase SND_SOC_TPLG_NUM_TEXTS to 32 to support 32 configs for a path.
What do you mean by "Topology supports maximum of 32 configs for a path"? I checked in alsa-lib and the same value of 16 is used. I don't get how a change at the kernel level is going to help if the information generated by alsatplg uses a different structure.
I also don't get how you enable this change, the code in skl-topology only accesses the .priv structure in the enum, but if you change the size of the texts array then all your pointers are incorrect so you'd handle garbage data.
Signed-off-by: Puneeth Prabhu puneethx.prabhu@intel.com Signed-off-by: Pardha Saradhi K pardha.saradhi.kesapragada@intel.com
include/uapi/sound/asoc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/sound/asoc.h b/include/uapi/sound/asoc.h index a74ca23..5b1411b 100644 --- a/include/uapi/sound/asoc.h +++ b/include/uapi/sound/asoc.h @@ -88,7 +88,7 @@ #define SND_SOC_TPLG_MAGIC 0x41536F43 /* ASoC */
/* string sizes */ -#define SND_SOC_TPLG_NUM_TEXTS 16 +#define SND_SOC_TPLG_NUM_TEXTS 32
/* ABI version */ #define SND_SOC_TPLG_ABI_VERSION 0x5 /* current version */