Re: [alsa-devel] [PATCH v6 10/15] ASoC: hdac_hdmi: Fix possible memory leak in hw_params

On Fri, Feb 12, 2016 at 07:46:10AM +0530, Subhransu S. Prusty wrote:

It's possible for hw_params to be called two times. So add NULL check to prevent memory leak.

Another fix?

• dd = kzalloc(sizeof(*dd), GFP_KERNEL);
• if (!dd)

• return -ENOMEM;
  

• dd = (struct hdac_ext_dma_params *)

• snd_soc_dai_get_dma_data(dai, substream);
  

If you need to cast away from void * that suggests a problem and it'd look a lot neater too.