Re: [alsa-devel] [PATCH 1/3] ASoC: support sample sizes properly in the WM8776 codec driver

Liam Girdwood wrote:

Sounds like we also need this for the other codec drivers too at some point.

Yes, but I can only test *this* codec on a big-endian system. :-)

...

/* Set word length */

• switch (params_format(params)) {
• case SNDRV_PCM_FORMAT_S16_LE:

• i = snd_pcm_format_width(params_format(params));
• switch (i) {

Just a minor nitpick. I would not have used the intermediate 'i' here and would have just embedded the snd_pcm call within the switch(). I guess it may not fit the line width though.

'i' is used twice:

switch (i) {

and

dev_err(codec->dev, "Unsupported sample size: %i\n", i);