alsa-project/alsa-gobject pull request #51 was opened from takaswie:
The patchset is the part of work about #47.
Current implementation uses library-wide error domain to report error. this is partly against rule of GError usage. Furthermore, the error delivers information just about errno and hard to know the cause of error.
This patchset enhances error reporting. The library-wide error domain is obsoleted. ALSAHwdep library is small and includes global functions. GFileError is used for the functions to report error since It has no specific error domain in current design.
``` Takashi Sakamoto (9): seq: query: remove duplicated semicolon ctl: query: simplify count check timer: instance_param: simplify count check hwdep: skip check of return value from g_malloc() hwdep: check whether method argument for GError is available hwdep: add checks for method arguments hwdep: query: simplify count check hwdep: query: use GFileError to report error hwdep; obsolete library-wide GQuark for error reporting
src/ctl/query.c | 9 ++-- src/hwdep/privates.h | 6 --- src/hwdep/query.c | 101 ++++++++++++++++-------------------- src/seq/query.c | 2 +- src/timer/instance-params.c | 5 +- 5 files changed, 50 insertions(+), 73 deletions(-) ```
Request URL : https://github.com/alsa-project/alsa-gobject/pull/51 Patch URL : https://github.com/alsa-project/alsa-gobject/pull/51.patch Repository URL: https://github.com/alsa-project/alsa-gobject