18 May
2021
18 May
'21
10:11 p.m.
18.05.2021 21:09, Rob Herring пишет:
+static const char * const tegra_active_low_hp_compats[] = {
- "ad,tegra-audio-plutux",
- "ad,tegra-audio-wm8903-medcom-wide",
- "ad,tegra-audio-wm8903-tec",
- "nvidia,tegra-audio-wm8903-cardhu",
- "nvidia,tegra-audio-wm8903-harmony",
- "nvidia,tegra-audio-wm8903-picasso",
- "nvidia,tegra-audio-wm8903-seaboard",
- "nvidia,tegra-audio-wm8903-ventana",
- NULL,
I think this list should be added to the main match table below with data having a flag for active low HP. Then you only match once, don't need the exported function and the next difference is much easier to add.
Thank you for the suggestion. You're right that these compats will take precedence.
I'm also now thinking that it should be okay to assume that the GPIO is active-low by default. I haven't seen tegra boards with the active-high configuration.
I'll remove the use of the exported function in v2.