On Tue, Dec 02, 2008 at 05:37:54PM +0100, Daniel Mack wrote:
On Thu, Nov 27, 2008 at 11:50:21AM +0000, Mark Brown wrote:
+#define AIC3X_HEADSET_DETECT_CELLULAR (2 << 5) +#define AIC3X_HEADSET_DETECT_BOTH (3 << 5)
What exactly is CELLULAR? A headset?
There is different types of headsets supported by this chip (see page 42 of the datasheet), and this bits define which types the detection should be enabled for.
I *belive* it's a headset but please submit a patch adding some text documenting this, ideally people shouldn't have to refer to the datasheet to use the driver.
Best regards, Daniel
- Add aic3x_set_headset_detection() function to define the headset detection mode for tlv32aic3x chips
- added aic3x_button_pressed()
- Read from the real-time registers in aic3x_headset_detected() to query headset presence without an occured interrupt
Signed-off-by: Daniel Mack daniel@caiaq.de
As I have repeatedly mentioned it would be very much better if you were to do your submissions in the standard fashion which is documented in Documentation/SubmittingPatches. The fact that you don't do this makes your patches more difficult to apply and doesn't encourage review.
Note in particular the --- above which causes your commit message to be removed.