On Fri, Jul 12, 2019 at 12:37:51PM +0900, Kuninori Morimoto wrote:
Hi Nathan
clang errors:
sound/soc/generic/audio-graph-card.c:87:7: error: assigning to 'u32 *' (aka 'unsigned int *') from 'const void *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers] reg = of_get_property(node, "reg", NULL); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated.
Move the declaration up a bit to keep the reverse christmas tree look.
Fixes: c152f8491a8d ("ASoC: audio-graph-card: fix an use-after-free in graph_get_dai_id()") Link: https://github.com/ClangBuiltLinux/linux/issues/600 Signed-off-by: Nathan Chancellor natechancellor@gmail.com
Maybe
ec3042ad39d4e2ddbc3a3344f90bb10d8feb53bc ("ASoC: audio-graph-card: add missing const at graph_get_dai_id()")
Thank you for your help !! Best regards
Kuninori Morimoto
Ugh, I even checked Mark's tree before sending this, just completely glossed over that patch. Sorry for the noise :(
Cheers, Nathan