Re: [PATCH 4/5] ASoC: wm8962: Fix wm8962_set_fll to use source instead of fll_id

On Wed, Mar 06, 2024 at 04:14:38PM +0000, Stuart Henderson wrote:

Previously wm8962_set_fll was using fll_id to configure the source.

Which was a problem because...?

This change is problematic, but it looks like there's limited users of this driver, and luckily they all seem to be intending to use WM8962_FLL_MCLK as the source which happens to have the same value as WM8962_FLL.

If the change is problematic why make it at all?