On Wed, Mar 16, 2011 at 12:38:57AM -0700, Reddy, MR Swami wrote:
Tested this patch on SMDK6410 platform with Kernel- 2.6.24 and ALSA version is - 1.0.15.
As previously mentioned you need to submit code against current Linux versions. Linux 2.6.24 is over three years old and development of the kernel has moved on substantially in that time.
Please review and let me know the comments/suggestion on this patch. And also let me know the forward-porting (to the latest ALSA version APIs) steps/process. Thanks in advance.
As previously mentioned this is pretty much up to you - you can apply a range of techniques, either from starting from scratch or reviewing the kernel changelogs for the core and other drivers and making gradual changes to forward port. Which approach works best for you is largely a matter of personal preference. If you have questions on specific things then please feel free to ask.
I've had a brief glance at the driver and there are a number of obvious coding style issues, please before resubmitting review the coding style you are using and ensure that your driver is following a similar coding style to the existing kernel code. For example comments like this:
+/***************************************************************************
- Name:
- lm49352_read_reg_cache- Reads specific register from reg cache.
- Synopsis:
static inline unsigned int
lm49352_read_reg_cache(struct snd_soc_codec *codec,unsigned int reg)
are not at all idiomatic for the kernel.