17 Sep
2007
17 Sep
'07
2:36 p.m.
At Mon, 17 Sep 2007 14:23:59 +0200, Krzysztof Helt wrote:
On Mon, 17 Sep 2007 13:01:42 +0200 Takashi Iwai tiwai@suse.de wrote:
I reject your patch not because of coding style but it changes the existing module option :-)
Can you keep the option dma and just add dma2?
Yes, of course.
Also, you changed the initialization of port[]. Any reason? Is the current code broken in that way?
No, the code is not broken. The changed way is exactly the same but shorter.
From the sound/initval.h:
#define SNDRV_DEFAULT_PORT { [0 ... (SNDRV_CARDS-1)] = SNDRV_AUTO_PORT }
I can leave old initialization if you prefer.
Ah, yes, then go ahead. It's more cleaner.
Thanks!
Takashi