On Friday 01 May 2009 05:47:22 ext Lopez Cruz, Misael wrote:
This patch adds voice downlink analog bypass switch. It follows the same approach as in other analog bypass switches. DAC switch is moved from 'DAC Voice' to 'Analog Voice Playback Mixer', that will also allow voice DAC to be powered in digital voice loopback (sidetone).
Signed-off-by: Misael Lopez Cruz x0052729@ti.com
Generally this looks good, but it would have been better if you sent this series in three parts (now the first patch is doing two things): 0001: ASoC: TWL4030: Enable master analog loopback 0002: ASoC: TWL4030: Add VDL analog bypass 0003: ASoC: TWL4030: ASoC: TWL4030: Add voice digital loopback: sidetone
There is no mention about the master analog loopback switch in the first patch...
Either you could resend the series or Mark can modify the commit message for the first patch: [PATCH 1/2] ASoC: TWL4030: Add VDL analog bypass and master loopback handling
Than to the end of the commit message: "Handle the master analog loopback control based on the state of analog loopback switches"
Otherwise: Acked-by: Peter Ujfalusi peter.ujfalusi@nokia.com