At Wed, 19 Sep 2007 08:47:23 +0900, Keita Maehara wrote:
At Tue, 18 Sep 2007 18:04:02 +0200, Takashi Iwai wrote:
At Wed, 19 Sep 2007 00:50:54 +0900, Keita Maehara wrote:
From: Keita Maehara maehara@debian.org
These patches enable a few YMF743 controls (Tone/3D/IEC958) that won't be detected with the current version of ALSA.
Signed-off-by: Keita Maehara maehara@debian.org
The changes look good to me, but I'd like to ask you to rewrite the patch to follow the standard coding style. Yes, the original ac97 code doesn't follow, but at least, we should do it right for the newly added/changed codes. For example, keep lines within 80 chars, fold lines appropriately, avoid if ((err = ...)) style, etc.
I was wondering whether to follow the coding style for them indeed but understood the policy now. Sorry to bother you.
In doubt, you can run scripts/checkpatch.pl in the linux kernel tree.
Now they're checkpatch-clean anyway. I've put the second version at http://people.debian.org/~maehara/alsa-ymf743.
Could you repost here again? Then I could give further review comments (if any).
thanks,
Takashi