At Fri, 13 Aug 2010 13:27:30 +0100 (BST), Mark Hills wrote:
On Wed, 11 Aug 2010, Takashi Iwai wrote:
At Wed, 11 Aug 2010 10:59:59 +0200, I wrote:
At Wed, 11 Aug 2010 09:04:32 +0100 (BST), Mark Hills wrote:
Hi, does anybody have any thoughts on my email below? The rate conversion code looks stable and untouched for a while.
I guess it's a missing support of 3-byte formats in 16bit conversion, so not specific to rate plugin.
Indeed, it's an obvious ommision now that you mention it! Thanks for the hint.
Adding the support shouldn't be too hard, since it's already found in 32bit conversion.
A quick (untested) fix is below.
Thanks, I tested your patch.
There's a minor mistake that prevents it working, and a couple of comments don't seem quite right (see below). I'll follow this email with a revised patch.
With my modified patch, I was able to play back reliably in both aplay and xwax on my S24_3BE device with rate conversion.
OK, thanks. Now applied your fix patch to git tree.
Takashi