On Thu, 24 Dec 2015 07:44:22 +0100, Takashi Iwai wrote:
On Thu, 24 Dec 2015 04:46:37 +0100, Hui Wang wrote:
From: Kailang kailang@realtek.com
The Lenovo ThinkCenter AIO uses Line2 (NID 0x1b) to implement the micmute hotkey, here we register an input device and use Line2 unsol event to collect the hotkey pressing or releasing.
In the meanwhile, the micmute led is controlled by GPIO2, so we use an existing function alc_fixup_gpio_mic_mute_hook() to control the led.
Cc: stable@vger.kernel.org Signed-off-by: Kailang kailang@realtek.com
Is it mandatory expose this as a key event? I mean, wouldn't it suffice just toggle the mic mute by the driver itself? User-space will get the notification by the mixer status change in anyway.
More specifically, what I thought of is symmetry: if a mute switch is implemented in a hard-coded way, we may follow the similar logic for the mic mute, too. OTOH, if a mute switch is handled in an open way using the normal key code, we should follow that for the mic mute, too, like this patch provides.
Takashi