Re: [alsa-devel] [PATCH] [PATCH V2] ASoC: SAMSUNG: Add WM8994 PCM Machine driver

On 20/06/11 09:29, Sangbeom Kim wrote:

This patch add WM8994 PCM machine driver to support PCM audio on SMDKV310, SMDKC210 boards. Playback and Capture supports 8kHz sampling rates. and It is tested on SMDKV310, SMDKC210.

Signed-off-by: Sangbeom Kim sbkim73@samsung.com

sound/soc/samsung/Kconfig | 8 ++ sound/soc/samsung/Makefile | 2 + sound/soc/samsung/smdk_wm8994pcm.c | 176 ++++++++++++++++++++++++++++++++++++ 3 files changed, 186 insertions(+), 0 deletions(-) create mode 100644 sound/soc/samsung/smdk_wm8994pcm.c

Acked-by: Liam Girdwood lrg@ti.com

+static int smdk_wm8994_pcm_hw_params(struct snd_pcm_substream *substream,

• 	      struct snd_pcm_hw_params *params)
  

+{

• struct snd_soc_pcm_runtime *rtd = substream->private_data;
• struct snd_soc_dai *codec_dai = rtd->codec_dai;
• struct snd_soc_dai *cpu_dai = rtd->cpu_dai;
• unsigned long mclk_freq;
• int rfs, ret;
• switch(params_rate(params)) {

Minor issue, there should really be a space after switch. You could send this incrementally.

Thanks

Liam