Re: [alsa-devel] [PATCH] ALSA: ASoC: Add codec driver for AK5386

On Fri, Mar 08, 2013 at 12:07:28PM +0100, Daniel Mack wrote:

Adds a driver for Asahi Kasei's AK5386 Single-ended 24-Bit 192kHz delta-sigma ADC. The device has no control port interface but an optional RESET/PDN GPIO pin.

Applied, thanks. One possible update...

• /*

• * From the datasheet:
  

• *
  

• * All external clocks (MCLK, SCLK and LRCK) must be present unless
  

• * PDN pin = “L”. If these clocks are not provided, the AK5386 may
  

• * draw excess current due to its use of internal dynamically
  

• * refreshed logic. If the external clocks are not present, place
  

• * the AK5386 in power-down mode (PDN pin = “L”).
  

• */
  

• if (gpio_is_valid(priv->reset_gpio))

• gpio_set_value(priv->reset_gpio, 1);
  

I think that mute_stream() which was recently added and I mentioned in my review of your previous patch would do what you want here idiomatically - the effect is about the same as a mute and it should be called bat the right moments.