Re: [alsa-devel] [PATCH v2] ASoC: PXA: Fix oops in __pxa2xx_pcm_prepare

On Sat, Apr 02, 2011 at 10:54:47AM +0300, Vasily Khoruzhick wrote:

pxa2xx_pcm_hw_free frees dma channel and sets prtd->dma_ch to -1, but does not set prtd->params to NULL, so if pxa2xx_pcm_hw_params will be called immediately, it leaves prtd->dma_ch initialized with -1, and it results in oops in __pxa2xx_pcm_prepare. This bug is triggered via SDL.

This patch adds check for prtd->dma_ch to __pxa2xx_pcm_prepare and cleans prtd->params, so now it works properly.

Applied, thanks.