30 Aug
2023
30 Aug
'23
5:55 p.m.
On 8/28/23 14:39, Mark Brown wrote:
On Mon, Aug 28, 2023 at 12:05:22PM -0500, Vlad Karpovich wrote:
+static int cs35l45_amplifier_mode_put(struct snd_kcontrol *kcontrol,
struct snd_ctl_elem_value *ucontrol)+{
- snd_soc_component_enable_pin_unlocked(component, "SPK");
- snd_soc_dapm_sync_unlocked(dapm);
- snd_soc_dapm_mutex_unlock(dapm);
- cs35l45->amplifier_mode = ucontrol->value.integer.value[0];
- return 0;
+}
This should return 1 on change (I did see that there's some code which generates notifications but it would still be better to flag changes here, it makes review a lot easier).
Thanks. I will update patch.