Re: [PATCH v3 1/2] ASoC: qcom: dt-bindings: Add sc7180 machine bindings

On Sat, Aug 1, 2020 at 2:32 AM Rob Herring robh@kernel.org wrote:

On Fri, Jul 31, 2020 at 04:40:22PM +0800, Cheng-Yi Chiang wrote:

...

Add devicetree bindings documentation file for sc7180 sound card.

Signed-off-by: Cheng-Yi Chiang cychiang@chromium.org

.../bindings/sound/qcom,sc7180.yaml | 113 ++++++++++++++++++ 1 file changed, 113 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/qcom,sc7180.yaml

diff --git a/Documentation/devicetree/bindings/sound/qcom,sc7180.yaml b/Documentation/devicetree/bindings/sound/qcom,sc7180.yaml new file mode 100644 index 000000000000..ce8a5a2d9df9 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/qcom,sc7180.yaml @@ -0,0 +1,113 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/qcom,sc7180.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#

+title: Qualcomm Technologies Inc. SC7180 ASoC sound card driver

+maintainers:

• • Rohit kumar rohitkr@codeaurora.org
• • Cheng-Yi Chiang cychiang@chromium.org

+description:

• This binding describes the SC7180 sound card which uses LPASS for audio.

+definitions:

Please don't use 'definitions'. Either just duplicate it or you can do 'patternProperties'.

Removed dai definition in v4.

...

• dai:
• type: object
• properties:

•  sound-dai:
  

•    maxItems: 1
  

•    $ref: /schemas/types.yaml#/definitions/phandle-array
  

•    description: phandle array of the codec or CPU DAI
  

This is a common property. You can assume we have a common schema definition for it. IOW, 'sound-dai: true' is enough as it's always a single phandle+args.

In the examples I found, Documentation/devicetree/bindings/sound/amlogic,gx-sound-card.yaml, Documentation/devicetree/bindings/sound/samsung,midas-audio.yaml use:

sound-dai: $ref: /schemas/types.yaml#/definitions/phandle description: phandle of the CPU DAI

Documentation/devicetree/bindings/sound/simple-card.yaml just use

sound-dai: maxItems: 1

In v4, I used 'sound-dai: true' as suggested.

But I am a bit confused about assuming there is a common schema definition for it. I checked the code at https://github.com/devicetree-org/dt-schema but did not found the definition for it. Did I miss something here ?

Thanks for the help!

...

• required:

•  - sound-dai
  

+properties:

• compatible:
• contains:

•  const: qcom,sc7180-sndcard
  

• audio-routing:
• $ref: /schemas/types.yaml#/definitions/non-unique-string-array
• description:

•  A list of the connections between audio components. Each entry is a
  

•  pair of strings, the first being the connection's sink, the second
  

•  being the connection's source.
  

• model:
• $ref: /schemas/types.yaml#/definitions/string
• description: User specified audio sound card name
• aux-dev:
• $ref: /schemas/types.yaml#/definitions/phandle
• description: phandle of the codec for headset detection

+patternProperties:

• "^dai-link(@[0-9]+)?$":
• description:

•  Each subnode represents a dai link. Subnodes of each dai links would be
  

•  cpu/codec dais.
  

• type: object
• properties:

•  link-name:
  

•    description: Indicates dai-link name and PCM stream name.
  

•    $ref: /schemas/types.yaml#/definitions/string
  

•    maxItems: 1
  

•  cpu:
  

•    $ref: "#/definitions/dai"
  

•  codec:
  

•    $ref: "#/definitions/dai"
  

• required:

•  - link-name
  

•  - cpu
  

•  - codec
  

• additionalProperties: false

+examples:

• • |
• sound {

•    compatible = "qcom,sc7180-sndcard";
  

•    model = "sc7180-snd-card";
  

•    audio-routing =
  

•                "Headphone Jack", "HPOL",
  

•                "Headphone Jack", "HPOR";
  

•    aux-dev = <&alc5682>;
  

•    #address-cells = <1>;
  

•    #size-cells = <0>;
  

•    dai-link@0 {
  

•        link-name = "MultiMedia0";
  

•        cpu {
  

•            sound-dai = <&lpass_cpu 0>;
  

•        };
  

•        codec {
  

•            sound-dai = <&alc5682 0>;
  

•        };
  

•    };
  

•    dai-link@1 {
  

•        link-name = "MultiMedia1";
  

•        cpu {
  

•            sound-dai = <&lpass_cpu 1>;
  

•        };
  

•        codec {
  

•            sound-dai = <&max98357a>;
  

•        };
  

•    };
  

• };

-- 2.28.0.163.g6104cc2f0b6-goog