Re: [alsa-devel] [PATCH 1/2] ASoC: fsl_audmix: remove "model" attribute

Hi Viorel,

Few comments inline.

On Tue, Apr 9, 2019 at 11:36 AM Viorel Suman viorel.suman@nxp.com wrote:

Use "of_device_id.data" to specify the machine driver, instead of "model" DTS attribute.

<snip>

static int fsl_audmix_probe(struct platform_device *pdev) {

•   struct device *dev = &pdev->dev;
  

You might want to remove this change from the patch because it touches a lot of lines and it makes the review harder.

I don't see any reason to have it at all.

thanks, Daniel.