12 Jun
2020
12 Jun
'20
6:18 p.m.
Mark
On 6/12/20 11:09 AM, Mark Brown wrote:
On Fri, Jun 12, 2020 at 11:06:03AM -0500, Dan Murphy wrote:
- tas2562->sdz_gpio = devm_gpiod_get_optional(dev, "shut-down-gpio",
- tas2562->sdz_gpio = devm_gpiod_get_optional(dev, "shutdown", GPIOD_OUT_HIGH);
This also changes the name from shut-down to shutdown which will be incompatible (IIRC we do try -gpio as well as -gpios).
Yes the non-standardish name was highlighted by Rob[1].
Also I checked the GPIO library and it looks at both -gpio and gpios as property suffixes.
Since this is a single GPIO the singular should be used in this case
[1] https://lore.kernel.org/patchwork/patch/1251670/
Dan