On Wed, 5 Jan 2011 15:55:09 +0000 Mark Brown broonie@opensource.wolfsonmicro.com wrote:
On Wed, Jan 05, 2011 at 05:46:00PM +0200, Jarkko Nikula wrote:
This support could have been implemented earlier but I was targeting to have ASoC cross-device support first. But as there's no DAPM widgets anymore in TPA6130, I don't see any other way to implement this than by registering TPA6130 controls to aic34a with tpa6130a2_add_controls and by using tpa6130a2_stereo_enable.
Having thought about it for at least a second I think we should have a DAPM context in the cards for all the board-level stuff - does that seem resonable? The patch itself looks good:
I don't know. Probably it would be good if machine widgets are in own context. Like having own debugfs/sysfs directory for them etc.
In this case it would be just enough if the tpa6130 is a codec driver having DAPM widgets. Then machine driver wouldn't need any these exported special tpa6130a2_ functions and soc-dapm could take care of power changes according to audio map and other info.
But as far as I understood there's no any better way to get rid of pops in tpa6130a2.