On Mon, 17 Sep 2007 14:34:39 +0200 Takashi Iwai tiwai@suse.de wrote:
At Sun, 16 Sep 2007 19:01:32 -0400, J. Scott Merritt wrote:
In salsa-lib 0.0.11, pcm-macros.h : line 229
snd_pcm_drain calls the ioctl with SNDRV_PCM_IOCTL_DROP. (seemingly confusing -drop- with -drain-)
Is there any reason that this shouldn't be changed to call the ioctl with SNDRV_PCM_IOCTL_DRAIN ?
Sure, it's a typo :)
Fixed and released as 0.0.12 now. Thanks!
Takashi
Thanks Takashi,
I do not yet see 0.0.12 on the FTP server (ftp.suse.com/pub/people/tiwai/salsa-lib), but I'm sure it will be there shortly.
However, if you are preparing another SALSA release, you might also want to consider including:
pcm->stream = stream;
somewhere around line 133 in pcm.c (as per my message snd_pcm_avail_update on 14-Sep-2007).
Thanks, Scott.