Mark Brown wrote:
On Fri, Sep 26, 2008 at 11:24:10AM +0200, Sedji Gaouaou wrote:
This last patch contains the board specific files. I have not changed playpaq_wm8510.c, and I did few changes on eti_b1_wm8731.c.
It'd be better to submit this as two separate patches, one making the modifications to eti_b1_wm8731.c and another doing the simple code move (in either order). This would make it easier to review the changes - due to the file move they're not really visible in the current patch.
It'd also be good to see acks from Frank and Geoffrey since I can't test any of this.
Thanks for doing this work - it looks good, unifying the support for the AT91 and AVR32 platforms is a substantial win and it's good to see Atmel contributing this support.
Sedji,
Thanks very much for your effort in creating the common Atmel SCC audio driver.
I would very much like to test your new ASoC platform driver, but unfortunately this will have to wait until we can upgrade the kernel in our product.
That being said, I am wondering if it is worth keeping eti_b1_wm8731.c in the kernel.
I originally included eti_b1_wm8731.c in the kernel as an example of a machine driver for others who wanted to use the AT91 ASoC driver. The ETI_B1 board is specific to our product and we have no plans to ever sell it.
Now that there are other Atmel ASoC machine drivers in the kernel, and given the fact that our company does not have the resources to actively maintain it, I think the eti_b1_wm8731.c driver should be removed.
This reduces the effort in maintaining ASoC, as eti_b1_wm8731.c would no longer have to be kept up-to-date with ASoC changes. It also eases the pressure on me to test ASoC updates against eti_b1_wm8731.c as they are made.
So unless you or Mark feels the eti_b1_wm8731.c driver should remain in the kernel source, I'll submit a patch to remove it after your patches are in place.
Regards, ../fam