At Sun, 7 Jun 2009 22:46:51 -0400, Dan Allongo wrote:
I've been posting on the alsa-users list and I think I finally have a working patch now that I'd like to submit. The C-Media 6206 device is based off of CM106 and just needed a boot quirk added to set the registers properly for output. At least one other user can confirm that this patch works and that the SPDIF-out is also functioning now with this change. This is diff'd against today's snapshot so it should be good to go. Let me know if there's anything else that I need to do or change with this.
Thanks for the patch! I'd like certainly to apply it, however...
- return snd_usb_cm106_write_int_reg(dev, 0, 0x200c) +
snd_usb_cm106_write_int_reg(dev, 1, 0x3000) +snd_usb_cm106_write_int_reg(dev, 2, 0xf800) +snd_usb_cm106_write_int_reg(dev, 3, 0x143f) +snd_usb_cm106_write_int_reg(dev, 4, 0x0000) +snd_usb_cm106_write_int_reg(dev, 5, 0x3000);
Summing the return values here look weird. You want to return an error code, right? Then use a simple if sequence, or write a loop there.
Also, run $LINUX/scripts/checkpatch.pl to your patch and fix errors / warnings suggested there. Then please repost the patch with your sign-off.
thanks,
Takashi