On Fri, 10 Jun 2011 12:35:30 +0100 Mark Brown broonie@opensource.wolfsonmicro.com wrote:
On Fri, Jun 10, 2011 at 02:28:55PM +0300, Jarkko Nikula wrote:
- if (mcbsp_data->active)
return 0;Shouldn't we be returning -EBUSY or something here so the caller knows we didn't do what it asked (after checking to make sure it's not just trying to set the existing configuration)? Otherwise it might get surprised, assume the new configuration and just move the bug elsewhere.
I was thinking to return -EBUSY here but went thinking is it really worth of trouble? Machine drivers are calling this from their hw_params callback with the same configuration always (I suppose) for both playback and capture and it sounded kind of overkill to check what is existing configuration or skip the -EBUSY error.