On Thu, Sep 04, 2008 at 07:48:02AM -0700, Steve Sakoman wrote:
On Thu, Sep 4, 2008 at 5:04 AM, Mark Brown broonie@sirena.org.uk wrote:
Normally SND_SOC_BIAS_STANDBY would leave Vmid enabled but your power down function turns it off. The normal thing here is to have standby bring the codec up and then apply relatively small tweaks in _ON and
...
Does the codec have any bypass paths that can be set up? If not it shouldn't do much harm either way until you implement DAPM.
How about I add a "TODO" on this? I'm swamped for the next few weeks and won't be able to give it the attention it deserves test-wise.
Like I say, if the codec/driver implement any bypass paths (paths that carry audio from the inputs to the outputs without using the DAC or ADC) then it'll break those - the device will be brought down to standby when there is no playback or record going, which will power the bypass paths down. If that is an issue then documenting it (ideally with printks for users) should cover it for now.
If there aren't any bypass paths then it should be fine to leave it as-is.