Hi,
On Jun 21 2017 00:35, Takashi Iwai wrote:
Hi,
this is a patchset for alsa-lib corresponding to the patchset I've sent for kernel. The first two patches do the actual fixes, while the last two are merely cleanups / optimizations.
thanks,
Takashi
===
Takashi Iwai (4): pcm: hw: Add the support for explicit sync of appl_ptr pcm: hw: Call USER_PVERSION ioctl at open pcm: hw: Remove superfluous call of snd_pcm_set_appl_ptr() pcm: hw: Reduce redundant sync_ptr() calls
include/sound/asound.h | 4 +++- src/pcm/pcm_hw.c | 47 ++++++++++++++++++++++++++++++++--------------- 2 files changed, 35 insertions(+), 16 deletions(-)
I support this patchset.
Reviewed-by: Takashi Sakamoto o-takashi@sakamocchi.jp Tested-by: Takashi Sakamoto o-takashi@sakamocchi.jp
I did quick test with my devices and patched driver, running with kernel in 'topic/pcm-sync-applptr' branch[1]. I prepare for below four cases with combinations between ALSA fireworks driver and alsa-lib:
- driver with/without the flag - alsa-lib with/without the patch
As long as checking logs from trace-cmd and strace, I got expected results in all of these cases.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git/log/?h=topic...
Thanks
Takashi Sakamoto