15 Nov
2022
15 Nov
'22
11:14 a.m.
On Mon, Nov 14, 2022 at 10:14:19AM -0600, Pierre-Louis Bossart wrote:
On 11/14/22 04:29, Charles Keepax wrote:
It is rather inefficient to be constantly enabling/disabling the PM runtime as we print out each individual register, switch to holding a PM runtime reference across the whole register output.
the change is good, but technically the pm_runtime resume happens for the first read and suspend with a delay if use_autosuspend() is enabled, so presumably we'll see the same number of resume/suspend with the existing code and the suggested change.
Maybe update the commit message to mention that we constantly change reference counts, as you did in the next patch?
Yeah agree, I will respin the commit message.
Thanks, Charles