Hi Jassi,
Do you have a plan to move or create the sound/soc/samsung or others for future Samsung SoCs? And can you make a document which SoCs use I2S version? e.g., s3c24xx use I2Sv3 s3c64xx use I2Sv3 or 4?? s5p64xx use I2Sv4 s5pc1xx use I2Sv5 and so on
How about to give name samsung-i2cvx for common use instead of cpu name?
Thank you, Kyungmin Park
On Tue, Apr 27, 2010 at 1:25 PM, jassi brar jassisinghbrar@gmail.com wrote:
On Tue, Apr 27, 2010 at 11:58 AM, Ben Dooks ben-linux@fluff.org wrote:
On Wed, Mar 10, 2010 at 02:23:15PM +0000, Mark Brown wrote:
On Wed, Mar 10, 2010 at 04:48:55PM +0900, Jassi Brar wrote:
I have prepared some patches that debug and modify the behaviour of extant S3C I2S support towards managing I2Sv4 controllers as well.
OK, I think that's everything. I've not applied anything after the header move yet due to the need for an ack from Ben. Any patches I didn't specifically comment on are OK. Overall it's all good, most of the issues are minor.
I'd like to see a bit of header reformatting to make them readable if they're not already merged.
Ok.
the header moves are ok by me, much prefer to see them git mv'd than copy and rm'd.
Ok, I will move the header. Though the original plan was to create a copy in sound/soc/s3c24xx and render useless the one in plat-samsung/include/plat/ which could be independently removed from your tree. That was meant to avoid cross tree changes. _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel