On 10/03/14 23:40, Mark Brown wrote:
On Mon, Mar 10, 2014 at 06:15:55PM +0000, Ben Dooks wrote:
+/* wrapper functions to show any errors to updating register values */
+static inline int ak4642_update_bits(struct snd_soc_codec *codec,
unsigned int reg,unsigned int mask, unsigned int val)+{
- int ret = snd_soc_update_bits(codec, reg, mask, val);
- if (ret < 0) {
pr_info("%s: error %d writing %04x (%08x, mask %08x)\n",codec->name, ret, reg, mask, val);Two things here. One is that this should be a dev_err() and the other is that if this is worth doing shouldn't it just be in the core - I see nothing driver specific here?
Sorry, didn't see a device in "struct snd_soc_codec *codec" so I went for a printk (although it was pr_info instead of pr_err).
I did think if this should be something in the snd_soc_update_bits and snd_soc_write() calls after sending the patch.
If you think that changing the two snd_soc calls to print errors when anything bad happens then that would also be a good idea then I can send a patch for that.