Re: [PATCH 1/2] ASoC: add support for TAS5805M digital amplifier

On Tue, Jan 11, 2022 at 05:13:11PM +0000, Mark Brown wrote:

...

+static void tas5805m_refresh_unlocked(struct snd_soc_component *component) +{

• struct tas5805m_priv *tas5805m =

• snd_soc_component_get_drvdata(component);
  

• uint8_t v[4];
• unsigned int i;
• uint32_t x;

...

• snd_soc_component_write(component, REG_PAGE, 0x00);
• snd_soc_component_write(component, REG_BOOK, 0x8c);
• snd_soc_component_write(component, REG_PAGE, 0x2a);

This isn't using the regmap paging support and I'm not seeing anything that resets the page here.

Hi Mark,

The blob of register writes we get given from PPC3 contains a whole lot of explicit page and book changes, and there's not an easy way to tell regmap about this, as far as I know. Do you think it's acceptable to stick with explicit paging for this reason, or is there a way to make this work with regmap's paging?

I'll go ahead and address your other comments before resubmitting.

Cheers, Daniel