On Fri, Dec 5, 2008 at 3:00 PM, Mark Brown broonie@sirena.org.uk wrote:
On Fri, Dec 05, 2008 at 02:45:04PM +0200, Jarkko Nikula wrote:
On Thu, Dec 4, 2008 at 8:37 PM, Mark Brown broonie@sirena.org.uk
wrote:
I can't help thinking that it'd be easier to just use "Left Line" and "Right Line" but that's an existing issue in the driver.
Yeah, same thoughts. Started to look only now, but what's the idea to separate stereo control into two mono control in commit 54f01916297bafc18bd7df4e2300a0544a84fce3? Change like
Several codecs do this - systems often end up doing things like using the line inputs as unrelated mono paths rather than as a stereo path. How likely that is to happen with this codec I don't know.
Or did I read the idea of patch wrong? Before there were stereo contol for
PGAL -> HPL PGAR -> HPR
and now
PGAL -> HPL PGAL -> HPR
PGAR seems to be missing?
- SOC_DOUBLE_R("HP PGA Bypass Playback Volume", PGAL_2_HPLOUT_VOL, - PGAR_2_HPROUT_VOL, 0, 0x7f, 1), + SOC_SINGLE("HPL PGA Bypass Playback Volume", PGAL_2_HPLOUT_VOL, + 0, 0x7f, 1), + SOC_SINGLE("HPR PGA Bypass Playback Volume", PGAL_2_HPROUT_VOL, + 0, 0x7f, 1),
Codec itself can route all Line2[L | R], PGA [L | R], DAC [L | R] into all seven output stages. Which are Mono, Line [L |R] and HP [H |L] with HP having own volumes for HP positive and negative.
Jarkko