8 Apr
2015
8 Apr
'15
1:38 p.m.
1) We can't apply this patch on its own so this way of breaking up the patches doesn't work.
2) I was thinking that all the ->attach() calls would have to succeed or we would bail. Having some of them succeed and some fail doesn't seem like it will simplify the driver code very much. But I can also see your point. Hm...
Minor comment: No need to preserve the error code if there are lots which we miss. We may as well hard code an error code. But that's a minor thing. Does this actually simplify the driver code? That's the more important thing.
regards, dan carpenter