3 Apr
2014
3 Apr
'14
11:33 p.m.
On Thu, Apr 03, 2014 at 11:33:15PM +0800, Nicolin Chen wrote:
On Thu, Apr 03, 2014 at 03:53:36PM +0800, Axel Lin wrote:
- ret = regmap_read(cs42xx8->regmap, CS42XX8_CHIPID, &val);
- if (ret < 0) { dev_err(dev, "failed to get device ID: %x", val);
%d and ret would be better here since val won't be useful in this case.
Yes, they would - val won't have anything in particular in it if the I/O fails.