15 Dec
2008
15 Dec
'08
5:05 p.m.
On Mon, Dec 15, 2008 at 04:59:56PM +0100, Takashi Iwai wrote:
Mark Brown wrote:
Include sound/core.h in sound_core.c so that sound_class is declared before it is defined, avoiding it looking like it should be static.
It's a question whether it should be in linux/sound.h or in sound/core.h, but as long as it's declared in the latter file, I think it's OK to included it from sound_core.c although it's not ALSA-specific.
Yeah, the OSS code doesn't use the prototype from the header at all but instead has a local prototype in one of their C files which isn't terribly clever.