At Tue, 05 Nov 2013 09:27:10 +0100, Clemens Ladisch wrote:
Takashi Iwai wrote:
You wanted to play back via this HDMI and it didn't work?
The ATI card did not show up as "ATI", but the other ATI card without HDMI did: http://thread.gmane.org/gmane.linux.alsa.user/37732.
Anyway, let's close this thread:
--8<---------------------------------------------------------------->8-- ALSA: hda: add device IDs for AMD Evergreen/Northern Islands HDMI
The device IDs of the AMD Cypress/Juniper/Redwood/Cedar/Cayman/Antilles/ Barts/Turks/Caicos HDMI HDA controllers were missing for some reason. Add them so that the name shows up properly as "ATI HDMI" instead of "Generic", and so that the driver does not try to detect nonexistent codecs.
Well, there is no actual behavior difference between AZX_DRIVER_ATIHDMI and AZX_DRIVER_GENERIC about AMD HDMI chips. The codec-probing is pretty same. The only difference in the current code is the driver name string and the fallback of number of streams, but the latter is valid only when GCAP register doesn't give proper values, and it shouldn't happen with a proper chip.
That being said, the entries weren't added intentionally just because they aren't needed to be added explicitly. The generic entry suffices from the functionality POV.
But it seems that people misunderstand, so I think it's fine to apply your patch to give a more clear name.
Takashi
According to Takashi's tests and the lack of complaints, these devices work fine without disabling snooping.
Signed-off-by: Clemens Ladisch clemens@ladisch.de
--- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -4079,6 +4079,22 @@ .driver_data = AZX_DRIVER_ATIHDMI | AZX_DCAPS_PRESET_ATI_HDMI }, { PCI_DEVICE(0x1002, 0xaa48), .driver_data = AZX_DRIVER_ATIHDMI | AZX_DCAPS_PRESET_ATI_HDMI },
- { PCI_DEVICE(0x1002, 0xaa50),
.driver_data = AZX_DRIVER_ATIHDMI | AZX_DCAPS_PRESET_ATI_HDMI },
- { PCI_DEVICE(0x1002, 0xaa58),
.driver_data = AZX_DRIVER_ATIHDMI | AZX_DCAPS_PRESET_ATI_HDMI },
- { PCI_DEVICE(0x1002, 0xaa60),
.driver_data = AZX_DRIVER_ATIHDMI | AZX_DCAPS_PRESET_ATI_HDMI },
- { PCI_DEVICE(0x1002, 0xaa68),
.driver_data = AZX_DRIVER_ATIHDMI | AZX_DCAPS_PRESET_ATI_HDMI },
- { PCI_DEVICE(0x1002, 0xaa80),
.driver_data = AZX_DRIVER_ATIHDMI | AZX_DCAPS_PRESET_ATI_HDMI },
- { PCI_DEVICE(0x1002, 0xaa88),
.driver_data = AZX_DRIVER_ATIHDMI | AZX_DCAPS_PRESET_ATI_HDMI },
- { PCI_DEVICE(0x1002, 0xaa90),
.driver_data = AZX_DRIVER_ATIHDMI | AZX_DCAPS_PRESET_ATI_HDMI },
- { PCI_DEVICE(0x1002, 0xaa98),
{ PCI_DEVICE(0x1002, 0x9902), .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI }, { PCI_DEVICE(0x1002, 0xaaa0),.driver_data = AZX_DRIVER_ATIHDMI | AZX_DCAPS_PRESET_ATI_HDMI },