4 Apr
2014
4 Apr
'14
1:16 p.m.
Hi Clemens,
(Apr 04 2014 06:16), Clemens Ladisch wrote:
Takashi Sakamoto wrote:
This commit adds proc interface to output infomation for debugging.
- firmware information
- sampling rate and clock source
- physical metering (linear value)
+++ b/sound/firewire/fireworks/fireworks.c @@ -133,6 +133,16 @@ get_hardware_info(struct snd_efw *efw)
- /* hardware metering */
- efw->phys_out = hwinfo->phys_out;
- efw->phys_in = hwinfo->phys_in;
- efw->phys_out_grp_count = hwinfo->phys_out_grp_count;
- efw->phys_in_grp_count = hwinfo->phys_in_grp_count;
The driver relies on these values being correct. It will blow up if^H^Hwhen the firmware makes these values overflow.
Hm. Actually, the value of 'phys_xxx_grp_count' is expected less than 8 (HWINFO_MAX_CAPS_GROUPS). And I know the maximum number of 'phys_xxx' for all of models.
So I'll add to check these numbers for this purpose.
Thank you
Takashi Sakamoto o-takashi@sakamocchi.jp